resolves 2391 : Implement setConfigFiles method for handling multiple configuration f… #2392
+11,579
−3,535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles and update related tests Add multi-config Environment support Fixes #2391
vincentchabannes
approved these changes
Oct 28, 2025
…tegration [ci skip]
…12.1.0; refactor exception handling to improve formatting [ci skip]
…ithub.com/feelpp/feelpp into 2391-add-multi-config-environment-support
|
Stale pull request message |
move to c++20 by default but c++23 works as well Add multi-config Environment support Fixes #2391
… and consistency across various files in the feelpp library. - Updated operators3.hpp, pow.hpp, print.hpp, rand.hpp, redux.hpp, set.hpp, shape.hpp, stdmathfunctors.hpp, symbolsexpr.hpp, symm.hpp, time.hpp, trace.hpp, trans.hpp, tresca.hpp, twovalued.hpp, unary.hpp, val.hpp, vonmises.hpp to use static inline const for boolean and integral constants. - Added a new script generate-presets.sh to automate the generation of CMakePresets.json from CMakePresets.jsonnet.
…d image handling huge simplification of our docker workflow
- Changed the default job count from 25 to 4 in the test preset. - Updated component presets to inherit from default and use 4 jobs instead of the previous configuration. skip=feelpp
… the repo conditionally skip=feelpp
only=feelpp-full
- Use v1.12 with auto-detect full mode support - Add fullBuild.targets for mode-specific targets - Add debug output for planner results - Now `only=feelpp-full` auto-switches to full mode 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Replaced SFINAE patterns with C++20 concepts in various headers including check.hpp, concepts.hpp, csrgraphblocks.hpp, and others. - Updated function templates to use `requires` clauses for better readability and maintainability. - Enhanced type checking for mesh entities, function spaces, and field types using concepts. - Improved the clarity of function signatures by removing unnecessary template parameters and using concepts for constraints. - Ensured backward compatibility with existing functionality while transitioning to modern C++ standards. mode=full
- Introduced workflow presets for streamlined configure, build, and test processes. - Added simple and Docker workflow definitions for various components. - Updated CMake version requirement to 3.25 to support new features. - Included a new configuration variable FEELPP_ENABLE_QUICKSTART set to 'OFF'. [ci skip]
- Updated the `dim_t` and `order_t` templates in `discretizationsdescr.hpp` to utilize C++20 `requires` clauses for better readability and clarity. - Modified the `mesh_t` template in `traits.hpp` to apply a `requires` clause, ensuring that the provided `MeshType` is derived from `MeshBase`. only=feelpp
…ages for Feel++, Toolboxes, MOR, and Python
…m:feelpp/feelpp into 2391-add-multi-config-environment-support [ci skip]
… logic for test execution
…m:feelpp/feelpp into 2391-add-multi-config-environment-support
…xes for faster CI builds skip=feelpp
…or enabled toolboxes skip=feelpp
vincentchabannes
approved these changes
Jan 9, 2026
| { | ||
| VLOG(2) << "configuring PC... (sub: " << this->sub() << ")"; | ||
| //PCSetOptionsPrefix( pc, (this->prefix()+"_").c_str()); | ||
| #if !defined(FEELPP_HAS_SPDLOG) |
Member
There was a problem hiding this comment.
SPDLOG dependency is required, no? All #if #endif can be removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only=feelpp,testsuite