Skip to content

Proposal: Add memcpy and const #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaartenMJR wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Proposal: Add memcpy and const #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions mathc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ the following restrictions:
*/

#include "mathc.h"
#include <string.h>

#if defined(MATHC_USE_INT)
mint_t clampi(mint_t value, mint_t min, mint_t max)
Expand Down Expand Up @@ -1328,15 +1329,15 @@ mfloat_t *vec3_clamp(mfloat_t *result, mfloat_t *v0, mfloat_t *v1, mfloat_t *v2)
return result;
}

mfloat_t *vec3_cross(mfloat_t *result, mfloat_t *v0, mfloat_t *v1)
mfloat_t *vec3_cross(mfloat_t *result, const mfloat_t *v0, const mfloat_t *v1)
{
mfloat_t cross[VEC3_SIZE];
Copy link
Contributor Author

@MaartenMJR MaartenMJR Mar 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this specific case the local variable cross[] is not nessary and the results can directly be written into result[]

cross[0] = v0[1] * v1[2] - v0[2] * v1[1];
cross[1] = v0[2] * v1[0] - v0[0] * v1[2];
cross[2] = v0[0] * v1[1] - v0[1] * v1[0];
result[0] = cross[0];
result[1] = cross[1];
result[2] = cross[2];

memcpy(result, cross, sizeof(cross));

return result;
}

Expand Down