Support named filehandles in filehandle duplication #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for duplicating named filehandles like STDERR, STDOUT, and STDIN using the >&NAME syntax (e.g., open SAVEERR, '>&STDERR'). Previously, only numeric file descriptors were supported (e.g., >&2). This caused 'Unsupported filehandle duplication: STDERR' errors when running code that uses the common pattern of saving and restoring standard handles. The fix extends openFileHandleDup() to: - Handle STDIN, STDOUT, STDERR by name (case-insensitive) - Look up other named filehandles in the global IO table Added regression test filehandle_dup.t with 4 subtests covering: - Duplicating STDERR by name - Duplicating STDOUT by name - Duplicating by file descriptor number - Redirect and restore STDERR pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When running ExifTool with
JPERL_LARGECODE=refactor, the following error occurred:This was caused by code like:
Root Cause
IOOperator.openFileHandleDup()only supported numeric file descriptors (e.g.,>&2), not named filehandles like>&STDERR.Fix
Extended
openFileHandleDup()to handle:Testing
Added regression test
src/test/resources/unit/filehandle_dup.twith 4 subtests: