Remove code-generation time refactoring from EmitBlock #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove LargeBlockRefactorer.processBlock() call from EmitBlock.emitBlock() - Remove unused processBlock, shouldRefactorBlock, and tryWholeBlockRefactoring methods - Remove unused EmitterVisitor import - Refactoring now only happens at parse time via BlockNode constructor - This prevents AST modification during code generation phase
- Rewrite buildNestedStructure to place closures at tail position instead of head - This ensures variable declarations execute before closures that use them - Add variable declaration detection to shouldBreakChunk - Treat my/our/local declarations as chunk breakers to preserve lexical scope - Prevents variables from being hidden inside closures
- Remove error throwing when large blocks contain control flow statements - Simply skip refactoring for blocks with last/next/redo/goto - This accepts the limitation that some large blocks cannot be refactored - Fixes regressions in op/pack.t and re/pat_advanced.t
- Change isRefactoringEnabled to return true by default - Set JPERL_LARGECODE=disable to turn off refactoring - This is necessary since we removed code-gen time refactoring - Without this, large test files fail to compile - Fixes regression where op/pack.t and re/pat_advanced.t produced 0 tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes code-generation time AST refactoring from the EmitBlock class, ensuring that all refactoring happens exclusively at parse time.
Changes
LargeBlockRefactorer.processBlock()call fromEmitBlock.emitBlock()processBlock,shouldRefactorBlock, andtryWholeBlockRefactoringmethods fromLargeBlockRefactorerEmitterVisitorimportRationale
Refactoring should only happen during the parsing phase when the AST is being constructed. Modifying the AST during code generation violates the separation of concerns between parsing and code emission phases.
Impact
BlockNodeconstructor callingLargeBlockRefactorer.maybeRefactorBlock()