-
Notifications
You must be signed in to change notification settings - Fork 616
fix(py): add more test flows in evaluator demo to match JS SDK #4015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @MengqinShen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a significant overhaul of the Python evaluator demo, bringing its functionality and structure in line with the JavaScript SDK. The changes focus on enhancing the core Genkit framework's input handling and evaluator plugin capabilities, particularly for the faithfulness metric. The demo itself is now more comprehensive, showcasing various evaluation scenarios, RAG flows, and programmatic evaluation, supported by new datasets and clearer documentation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly overhauls the Python evaluator demo to match the functionality of the JS SDK. It introduces new flows, data, and prompts, providing a more comprehensive example of Genkit's evaluation capabilities. The changes also include important bug fixes in the evaluator plugin, such as correcting evaluator names and improving the logic for faithfulness evaluation.
My review has identified a couple of issues: a potential TypeError in the faithfulness evaluator when handling null context, and a critical return type mismatch in one of the new demo flows that would cause it to fail at runtime. I've provided code suggestions to address these issues. Overall, this is a valuable update that improves the evaluator demo and fixes underlying bugs.
These changes are to make py/samples/evaluator-demo mirrors js/testapps/evals folder
CHANGLOG: