Firey protons patch 1 #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding night mode and httpCall needs hex value for code sent in URL
added night mode and group as input set code input requirement to false as it is optional
fireboy1919
reviewed
Jun 26, 2018
Owner
fireboy1919
left a comment
fireboy1919
left a comment
There was a problem hiding this comment.
Other than that one comment, I'd love to accept this pull request.
It's a great addition!
| section("Light") { | ||
| input "miLightName", "text", title: "Light name", description: "i.e. Living Room", required: true, submitOnChange: false | ||
| input "code", "number", title: "Code", required: true, description: "Optional: will be autoassigned" | ||
| input "code", "number", title: "Code", required: false, description: "Optional: will be autoassigned" |
Owner
There was a problem hiding this comment.
Since this isn't actually autoassigned (because I couldn't figure out a way to do that after an hour or so of looking), this is actually needed, and the app was throwing exceptions when I didn't require it. So this would produce a bug.
Author
There was a problem hiding this comment.
I guess i felt like if something were optional, it shouldn't be required... :)
|
I can't seem to get nighten to work. There are no log messages so it isn't sending the HTTP request. Could someone confirm that it works? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added night-mode since sidoh's last update added it into the commands
the device's httpCall needed hexcode in the URL for mine to work with on/off commands...
I wanted some more flexibility with the group code, so I added it on installation.