FDS Validation: Update FM Burner cases with latest experimental data. #15782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@rmcdermo: I’ve created two pull requests: one for macfp-db and another for firemodels/fds to update the FM Burner validation case. The firemodels/fds PR hasn’t been merged yet. Would you like me to also update firemodels/out with the latest CSVs? Otherwise, the Validation Manual will fail. |
Contributor
|
@cxp484 we cannot change the guides until the data is in the out repo. And we cannot run the cases and put them into the out repo until they have a legit commit tag on master. So, please rework this PR to only contain changes to the FDS input files. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.