Skip to content

Conversation

@kozw
Copy link
Contributor

@kozw kozw commented Dec 17, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 17, 2025 11:04
@kozw kozw merged commit 2d8b4b6 into main Dec 17, 2025
3 checks passed
@kozw kozw deleted the copilot branch December 17, 2025 11:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds GitHub Copilot instructions to help AI assistants understand the firstfloor_calendar project's architecture, conventions, and development practices. The instructions provide comprehensive guidance on the two-layer architecture (document and semantic layers), code patterns, testing conventions, and CI/CD requirements.

  • Comprehensive documentation of the project's two-layer parsing architecture
  • Detailed development guidelines including CI requirements, commands, and test patterns
  • Reference information for key classes, methods, and known limitations

Comment on lines +88 to +96
Test helper pattern (inline ICS strings with CRLF):
```dart
final ics =
'BEGIN:VCALENDAR\r\n'
'VERSION:2.0\r\n'
...
'END:VCALENDAR';
final calendar = CalendarParser().parseFromString(ics);
```
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test pattern example shows explicit CRLF line endings, but many tests in the codebase (e.g., test/semantic/calendar_test.dart) use triple-quoted strings without explicit \r\n. While both patterns exist in the codebase, the instructions should clarify that triple-quoted strings are also commonly used and are automatically handled by the Dart parser. This would give developers flexibility in choosing the most readable approach for their tests.

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.28%. Comparing base (fd1b0e3) to head (64e622d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   97.28%   97.28%           
=======================================
  Files          15       15           
  Lines        2139     2139           
=======================================
  Hits         2081     2081           
  Misses         58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants