Skip to content

Conversation

@Karolk99
Copy link
Collaborator

Description

This PR updates openapi and fixes tests, unfortunately, until https://linear.app/swmansion/issue/FCE-2393/fishjam-webhooks is fixed tests won't pass.

Motivation and Context

Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.

Documentation impact

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

@linear
Copy link

linear bot commented Nov 26, 2025

@Karolk99 Karolk99 removed the request for review from AHGIJMKLKKZNPJKQR November 26, 2025 10:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the OpenAPI client models to reflect API changes and fixes test expectations accordingly. The main changes include introducing a structured Subscriptions model to replace a simple list, adding a ConflictError exception class, and updating the Stream model with a new field.

  • Replaced subscriptions from list[str] to a structured Subscriptions object with separate peers and tracks lists
  • Added ConflictError exception handling for HTTP 409 responses (previously treated as ServiceUnavailableError)
  • Added connected_viewers field to the Stream model

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/test_room_api.py Updated test assertions to use new Subscriptions model and corrected exception type from ServiceUnavailableError to ConflictError
fishjam/errors.py Added ConflictError exception class and HTTP 409 status code handling
fishjam/_openapi_client/models/subscriptions.py New model file defining the Subscriptions class with peers and tracks fields
fishjam/_openapi_client/models/stream.py Added connected_viewers field to track the number of connected viewers
fishjam/_openapi_client/models/peer.py Changed subscriptions attribute type from list[str] to Subscriptions object
fishjam/_openapi_client/models/init.py Exported the new Subscriptions model
fishjam/_openapi_client/api/room/add_peer.py Added handling for HTTP 409 (Conflict) responses
docker-compose-test.yaml Removed unused SIP and components configuration, and removed volume mount for test fixtures

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Karolk99 Karolk99 requested a review from ostatni5 November 26, 2025 11:47
@Karolk99 Karolk99 merged commit 63f666f into main Nov 26, 2025
9 of 12 checks passed
@Karolk99 Karolk99 deleted the FCE-2379/fix-python-tests branch November 26, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants