-
Notifications
You must be signed in to change notification settings - Fork 1
Add Gemini integration with optional dependencies #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds Gemini integration support to the Fishjam SDK with optional dependencies. The integration allows users to create Gemini clients with custom headers for SDK identification, while keeping the Gemini dependencies optional to avoid bloating installations for users who don't need this functionality.
Key changes:
- Added optional dependency group for Google Gemini integration
- Created version module to expose SDK version information
- Implemented Gemini integration wrapper with custom client creation
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pyproject.toml | Added gemini optional dependency group and reformatted workspace members list, removed trailing blank lines |
| fishjam/version.py | New module to retrieve and expose SDK version from package metadata |
| fishjam/integrations/gemini.py | New integration module providing Gemini client creation with Fishjam SDK headers |
| fishjam/init.py | Imported version module and exposed __version__ at package level |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 9 out of 11 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Added optional Gemini integration under
fishjam.integrations.geminiDocumentation impact
Types of changes
not work as expected)