Skip to content

Conversation

@p1003
Copy link
Contributor

@p1003 p1003 commented Dec 12, 2025

Description

Adds pre-commit

Motivation and Context

We want pre-commit

@p1003 p1003 requested a review from Copilot December 12, 2025 12:35
@p1003 p1003 self-assigned this Dec 12, 2025
@linear
Copy link

linear bot commented Dec 12, 2025

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds pre-commit configuration to the project to enable automated code quality checks before commits.

  • Adds pre-commit as a project dependency
  • Configures ruff linter as a pre-commit hook with auto-fix enabled

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
pyproject.toml Adds pre-commit 4.5.0 as a project dependency
.pre-commit-config.yaml Configures ruff v0.12.0 as a pre-commit hook with auto-fix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@p1003 p1003 marked this pull request as ready for review December 12, 2025 12:37
Copy link
Member

@AHGIJMKLKKZNPJKQR AHGIJMKLKKZNPJKQR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should probably be an instruction in the README.md on how to enable pre-commit

@p1003
Copy link
Contributor Author

p1003 commented Dec 17, 2025

There should probably be an instruction in the README.md on how to enable pre-commit

For me it worked right after I added it with uv. If you needed to do anything please add it to README, as I am no longer (at least for now) contributing to the project.

@AHGIJMKLKKZNPJKQR AHGIJMKLKKZNPJKQR merged commit c26b1a3 into main Dec 17, 2025
6 checks passed
@AHGIJMKLKKZNPJKQR AHGIJMKLKKZNPJKQR deleted the FCE-900 branch December 17, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants