Skip to content

Conversation

@PiotrWodecki
Copy link
Member

Description

Fixes an issue where docs generation needs the newly added optional Gemini dependency.

Documentation impact

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

@PiotrWodecki PiotrWodecki merged commit 09bcd5b into main Dec 12, 2025
10 checks passed
@PiotrWodecki PiotrWodecki deleted the fix-generate-docs branch December 12, 2025 15:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a documentation generation failure by ensuring optional dependencies (specifically the Gemini integration) are installed during the docs build process. The fishjam/integrations/gemini.py module requires the google-genai package, which is defined as an optional dependency. When pdoc attempts to generate documentation, it imports all modules including this integration, causing the build to fail without the optional dependencies.

  • Updates both documentation workflow files to install all extras and dev dependencies
  • Aligns the documentation workflows with the existing CI workflow pattern

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/tag_docs.yml Adds --all-extras --dev --all-packages flags to uv sync command to install optional dependencies needed for docs generation
.github/workflows/main_docs.yml Adds --all-extras --dev --all-packages flags to uv sync command to install optional dependencies needed for docs generation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants