-
Notifications
You must be signed in to change notification settings - Fork 9
bugfix/assignee_type_deprecation #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fivetran-savage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small question but nothing preventing approval, especially for pre-release. Approved!
CHANGELOG.md
Outdated
|
|
||
| | Data Model(s) | Change type | Old | New | Notes | | ||
| | ------------- | ----------- | ----| --- | ----- | | ||
| | `intercom__conversation_enhanced`<br>`intercom__conversation_metrics` | New field | | `conversation_assignee_id` | Exposes the assignee ID from the staging layer for reference and joining purposes | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a more explicit description of what the assignee_id field is/does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be useful to add that detail to the CHANGELOG. Added a short detailed description which mirrors the docs to the CHANGELOG entry in the latest commit.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
assignee_typefield from theCONVERSATION_HISTORYsource table as this has been deprecated. The field has been listed as deprecated and a new fieldis_assignee_adminis being added for use in the downstreamintercom__admin_metricsmodel.Submission Checklist
Changelog