Skip to content

Conversation

@fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Dec 17, 2025

PR Overview

Package version introduced in this PR:

  • v1.5.0

This PR addresses the following Issue/Feature(s):

  • Internal issue

Summary of changes:

  • Updates the dbt package to remove dependency on the assignee_type field from the CONVERSATION_HISTORY source table as this has been deprecated. The field has been listed as deprecated and a new field is_assignee_admin is being added for use in the downstream intercom__admin_metrics model.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • See internal ticket for details.
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-joemarkiewicz fivetran-joemarkiewicz added the docs:ready Triggers the docs generator workflow. label Dec 17, 2025
Copy link

@fivetran-savage fivetran-savage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small question but nothing preventing approval, especially for pre-release. Approved!

CHANGELOG.md Outdated

| Data Model(s) | Change type | Old | New | Notes |
| ------------- | ----------- | ----| --- | ----- |
| `intercom__conversation_enhanced`<br>`intercom__conversation_metrics` | New field | | `conversation_assignee_id` | Exposes the assignee ID from the staging layer for reference and joining purposes |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a more explicit description of what the assignee_id field is/does?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be useful to add that detail to the CHANGELOG. Added a short detailed description which mirrors the docs to the CHANGELOG entry in the latest commit.

@fivetran-joemarkiewicz fivetran-joemarkiewicz added the pre-release Triggers the auto-releaser workflow. label Dec 26, 2025
@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review December 29, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow. pre-release Triggers the auto-releaser workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants