Update vscode to 1.107.0 and fix startup on Wayland systems #636
Conversation
The branch 25.08 of the base app `org.electronjs.Electron2.BaseApp` already provides libsecret with the crypto backend disabled. Ref: flathub/org.electronjs.Electron2.BaseApp@24e075e
vscode has been updated to Electron 39, which uses Wayland by default on systems where the environment variable `XDG_SESSION_TYPE` is set to `wayland`. On these systems, vscode no longer starts if the Wayland socket is not present. This commit makes the Wayland socket available in the sandbox to fix this issue.
Signed-off-by: Jose Castillo Lema <josecastillolema@gmail.com>
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
❌ Test build failed. Help
|
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
✅ Test build succeeded. To test this build, install it from the testing repository: Built for aarch64 and x86_64 architectures. |
|
Works fine on wayland and also starts on X11 / Xwayland when enforcing it with this command: flatpak run --env=XDG_SESSION_TYPE=x11 --nosocket=wayland com.visualstudio.code//testPlease have a look, @bilelmoussaoui. |
xduugu
changed the title
| - /share/gtk-doc | ||
| - '*.la' | ||
| modules: | ||
| # Provide libsecret without gcrypt, forcing it to use the D-Bus backend |
There was a problem hiding this comment.
Ah, sorry. I forgot to add it to the PR description, it's only described in the commit message 8fed657:
Use libsecret from base app
The branch 25.08 of the base app
org.electronjs.Electron2.BaseAppalready
provides libsecret with the crypto backend disabled.
So it's only a minor cleanup. I made the same change already in the signal app without any issues, but I can remove it from this PR if you prefer.
|
Thanks for merging, @bilelmoussaoui, but apparently no build job was created for the merge commit. Do you happen to know how to manually trigger the build? |
|
The easiest way is to wait for another commit to happen, otherwise asking in flathub/flathub would help. |
|
Thanks, I have created a ticket there: flathub/flathub#7303 |
4 participants
vscode has been updated to Electron 39, which uses Wayland by default on systems where the environment variable
XDG_SESSION_TYPEis set towayland. On these systems, vscode no longer starts if the Wayland socket is not present.This commit makes the Wayland socket available in the sandbox to fix this issue.
Based on #635, includes #573.