Skip to content

fix: abort when no review entries are found for period #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pujux wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: abort when no review entries are found for period #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/__tests__/execute.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,14 @@ describe('execute', () => {
expect(github.getOctokit).toBeCalledWith(inputs.personalToken, { baseUrl: githubUrl });
});

it('aborts execution when no entries are found', async () => {
getEntries.mockResolvedValueOnce([]);
const results = await execute(inputs);
expect(results).toBeNull();
expect(getEntries).toBeCalled();
expect(publish).not.toBeCalled();
});

describe('Sponsorship', () => {
it('checks if the user is a sponsor', async () => {
checkSponsorship.mockResolvedValueOnce(true);
Expand Down
5 changes: 5 additions & 0 deletions src/execute.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ const run = async ({ inputs, octokit }) => {
});
core.debug(`Analyzed entries: ${entries.length}`);

if (entries.length === 0) {
core.info('No reviews found for the specified period.');
return null;
}

await publish({
core,
octokit,
Expand Down