-
Notifications
You must be signed in to change notification settings - Fork 545
in_opentelemetry: fix typo and sort configuration parameters #2298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughRenames config key Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@alexakreizinger a new PR with some changes for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pipeline/inputs/opentelemetry.md(2 hunks)
🔇 Additional comments (3)
pipeline/inputs/opentelemetry.md (3)
16-18: Keep key ordering consistent:buffer_chunk_sizeshould remain beforebuffer_max_size.This section looks correct as shown (and matches the PR objective).
43-46: Threading options ordering matches the stated convention.Placing
thread.ring_buffer.*beforethreadedimproves scanability and matches the PR objective.
49-51: TLS keys ordering matches the stated convention (tls.ciphersbeforetls.crt_file).Looks consistent with the sorting objective.
alexakreizinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a few suggestions, but pending those LGTM!
…ically - Fix typo: log_supress_interval → log_suppress_interval - Sort configuration parameters alphabetically: - buffer_chunk_size before buffer_max_size - thread.ring_buffer.* before threaded - tls.ciphers before tls.crt_file - Improve thread.ring_buffer.capacity and thread.ring_buffer.window descriptions - Add links to multithreading administration doc for threading parameters Applies to fluent#2209. Signed-off-by: Eric D. Schabell <eric@schabell.org>
cf9fc04 to
36e3bbc
Compare
|
Fixes and suggestions applied, merging. |
Applies to #2209.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.