-
Notifications
You must be signed in to change notification settings - Fork 25
Refactor: Consistent branch naming with ledger:branch format #1087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa79e4c to
23609e1
Compare
dpetran
reviewed
Sep 3, 2025
zonotope
approved these changes
Sep 4, 2025
Contributor
zonotope
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍶
dpetran
reviewed
Sep 5, 2025
dpetran
reviewed
Sep 5, 2025
Ensures storage paths don't include branch suffix (e.g., 'destined-for-drop' instead of 'destined-for-drop:main') to maintain backward compatibility with tests and existing storage structure
6b242ac to
c50e384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize branch naming to ledger:branch; reserve @ for time travel
Summary
Standardizes branch naming to
ledger:branch, removes branch segments from content‑addressed paths, and scopes nameservice records by branch. Consolidates branch handling and reserves@for time travel (PR #1088).Motivation
ledger:branchformat.@exclusively for time travel to align with forthcoming query semantics.Key Changes
ledger-name:branch-name(e.g.,my-ledger:main):reserved from ledger names;@reserved for time travel (e.g.,my-ledger:main@t:42)/to avoid unintended subdirectories/my-ledger/commit/[hash].json(deduped across branches)/ns@v1/my-ledger/main.json(supports ledger names with/)fluree.db.api/createrejects:in ledger names (:db/invalid-ledger-name)fluree.db.util.ledgerwithledger-base-name,ledger-branch,ledger-partsLedger; fixed circular depsImpact
:/Testing
Related Work
@-based query time travel:@t:<tx>,@iso:<timestamp>,@sha:<commit>, works withledger:branch@takes precedence over legacy?t=...; supports git‑style SHA prefixes