Consolidate index metadata extraction and prepare for nameservice-based index tracking #1146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonotope
reviewed
Oct 21, 2025
| (go-try | ||
| (let [commit-jsonld (commit-data/->json-ld commit) | ||
| (let [commit-jsonld (-> (commit-data/->json-ld commit) | ||
| (dissoc "index")) |
Contributor
There was a problem hiding this comment.
Right now we broadcast new indexes by publishing a new commit that includes an updated index map. I agree that we shouldn't overload these methods and that the latest commit and latest index should live in different data structures on the nameservice.
Does this pr add another way to publish new indexes since the index information is now stripped from the commit document?
Contributor
Author
There was a problem hiding this comment.
It was already ignored in the commit -- during load it gets it from the nameservice. So the commit index reference is not used at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralizes index metadata access patterns that were previously scattered across multiple modules and removes dead code from the commit workflow.
Removes 'index' from being written to commits going forward to focus on a single source of truth in nameservice. Currently index-t/address are embedded in commit so just dissoc from write for now, but in the future it should be held in a separate data structure outside of the commit that will hold other nameservice info.
Key changes:
Foundation for future work:
This refactoring prepares the codebase to migrate from storing index metadata in commits to using the nameservice as the system of record. The nameservice already tracks index address, index t, and status fields and is the only thing used, index metadata is already ignored in commits.
Future work will update callers to accept nameservice metadata to extract latest index, eliminating the need to duplicate index metadata in commit structures.