-
Notifications
You must be signed in to change notification settings - Fork 25
Explain Analyze #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dpetran
wants to merge
17
commits into
main
Choose a base branch
from
feature/explain-analyze
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Explain Analyze #1154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It hasn't been a tuple for years, and we are now showing the pattern name to users via the explain api, so renaming for consistency.
The explain api should be the same as the query api, and we also will need to support the :analyze option to report actual query statistics.
Removed the index updating for simple peek/pop as well.
5bb7f0a to
cefb5cf
Compare
The old implementation of explain duplicated all the work from optimize. Now that optimize is plan-driven, explain can be too.
cefb5cf to
4e11163
Compare
830ceec to
d678f32
Compare
This form of tracking is deliberately separate from the :meta opts - it should only be used with the explain api. When :analyze is specified all forms of tracking will be utilized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Refactors the explain api to be compatible with the
:analyzeoption and to account for heuristic-based optimization in addition to statistical reordering of patterns.