OpenTelemetry Tracing #1189
Merged
OpenTelemetry Tracing #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpetran
force-pushed
the
feature/otel-tracing
branch
3 times, most recently
from
8605f6d to
fa11a9a
Compare
We only want to include a logging facade in our classpath so that the calling application can supply their own logging implementation. Also add the Open Telemetry tracing facade.
clj-kondo does not execute code, so macros are never expanded, so the dependencies in fluree.db.util.trace don't look like they used. This suppresses the false positive warnings.
Eastwood warns that the `trace/form` macro expands to a suspicious expression: "suspicious-expression: with-open called with 1 args. (with-open bindings) always returns nil. Perhaps there are misplaced parentheses?" The `trace/form` invocations are the only places where the warning occurs, and in this case represent a valid usage of with-open.
dpetran
force-pushed
the
feature/otel-tracing
branch
from
fa11a9a to
36656d8
Compare
zonotope
approved these changes
Jan 16, 2026
|
|
||
| indexed-db)))) | ||
| db))) | ||
| (trace/async-form ::refresh {} |
Contributor
There was a problem hiding this comment.
Would it be useful to include the alias and t for the refreshed db in the attributes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a OpenTelemetry-compatible tracing facade and instruments the Fluree runtime. This allows us to correlate
dbwork across services and make flamegraphs to help identify performance bottlenecks.An example of a trace displayed in Jaeger:
An example of a span in Jaeger:
