fix: resolve flytestdlib test failures #6876
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix OpenTelemetry schema URL conflict in otelutils/factory.go by using resource.NewSchemaless() instead of resource.NewWithAttributes() to avoid schema version mismatch between resource.Default() and semconv/v1.26.0 - Skip TestAccessor_UpdateConfig k8s_configmaps test on macOS as fsnotify doesn't reliably detect symlink changes on Darwin systems. Also improved the test with a polling mechanism for more robust behavior on other platforms. Fixes: flyteorg#6856 Signed-off-by: Ankit Kumar Singh <ankitkumarsingh1702@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6876 +/- ##
=======================================
Coverage 56.95% 56.96%
=======================================
Files 929 929
Lines 58151 58150 -1
=======================================
+ Hits 33120 33124 +4
+ Misses 21989 21984 -5
Partials 3042 3042
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Closing this PR as it targets master. Will create a new PR targeting v2 branch as requested by @machichima. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the failing tests in flytestdlib as reported in #6856.
Changes Made
1. Fix OpenTelemetry Schema URL Conflict (
otelutils/factory.go)Problem:
TestRegisterTracerProviderWithContextwas failing with:Solution: Changed
resource.NewWithAttributes()toresource.NewSchemaless()to avoid schema URL conflicts when merging resources withresource.Default().2. Fix Flaky Config Accessor Test (
config/tests/accessor_test.go)Problem:
TestAccessor_UpdateConfig/[Viper]_Change_handler_k8s_configmapswas failing on macOS because fsnotify doesn't reliably detect symlink changes on Darwin systems.Solution:
t.Skip()for macOS systems since this is a known limitation of fsnotify with symlinksTesting
All tests pass:
Labels
fixedFixes #6856