refactor: centralize mockery definitions in .mockery.yaml #6877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR moves all //go:generate mockery comments to a centralized .mockery.yaml configuration file, making it easier to manage mock generation across the codebase. Changes: - Added .mockery.yaml with all mockery definitions organized by package - Removed //go:generate mockery comments from 107 Go files Fixes flyteorg#6815 Signed-off-by: Ankit Kumar Singh <ankitkumarsingh1702@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6877 +/- ##
==========================================
- Coverage 56.95% 56.95% -0.01%
==========================================
Files 929 929
Lines 58151 58151
==========================================
- Hits 33120 33119 -1
- Misses 21989 21990 +1
Partials 3042 3042
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Closing this PR as Issue #6815 was already solved by PR #6829. Thank you @machichima for the heads up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses #6815 by moving all
//go:generate mockerycomments to a centralized.mockery.yamlconfiguration file.Changes
Added
.mockery.yamlwith all mockery definitions organized by package sections:Removed
//go:generate mockerycomments from 107 Go files across the codebaseBenefits
Testing
Run
mockeryfrom the repository root to regenerate all mocks:Fixes #6815
Checklist
.mockery.yamlconfiguration file//go:generate mockerycomments