Add endpoint to translate raw json to inputs #6878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carina Ursu <carina@union.ai>
ursucarina
force-pushed
the
carina/translaterawjson
branch
from
8cfaf09 to
2949c12
Compare
EngHabu
approved these changes
Jan 31, 2026
EngHabu
reviewed
Jan 31, 2026
| // The type definitions (VariableMap) describing the expected structure. | ||
| flyteidl2.core.VariableMap variables = 1; | ||
| // The raw JSON values to convert to literals. | ||
| google.protobuf.Struct values = 2; |
Contributor
There was a problem hiding this comment.
Ketan was saying we should also allow this as the input for a CreateRun request.. which isn't a bad idea. You may still need this API for FE validation on the fly.. but the one in CreateRun request may simplify clients even more...
We can do it as a follow up.
EngHabu
changed the title
|
Congrats on merging your first pull request! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link