[Fix] Prevent uv.lock changes (#6845) #6879
Open
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new command "un-lock" to update the denpendency of uv.lock file. Prevent uv.lock changes during the "make gen" process. Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Update the uv version to 0.9.28 in CI image. Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related to: #6845
Why are the changes needed?
During
make genprocess,uv.lockfile always to be changed, but actually the dependencies don't have any update.if no dependencies are being updated,
uv.lockshouldn't be updated.What changes were proposed in this pull request?
Add new command
uv-lock. If any dependencies are updated, this command can be used to updateuv.lock.The original
make gencommand has been modified to only check ifuv.lockis the same as the current dependency.Reference: https://github.com/bufbuild/protovalidate-python/blob/48a8eaf955774f37b1f14455bb1e26b380e57e0b/Makefile#L75-L85
How was this patch tested?
Ensure
make genwill not makeuv.lockto be changed when no dependencies update.Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link