Skip to content

Conversation

@pingsutw
Copy link
Member

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Kevin Su <pingsutw@apache.org>
Copy link
Contributor

@davidmirror-ops davidmirror-ops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 75.22124% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.19%. Comparing base (bf665b9) to head (1430291).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
flytekit/core/type_engine.py 75.22% 25 Missing and 3 partials ⚠️

❗ There is a different number of reports uploaded between BASE (bf665b9) and HEAD (1430291). Click for more details.

HEAD has 15 uploads less than BASE
Flag BASE (bf665b9) HEAD (1430291)
18 3
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3377       +/-   ##
===========================================
- Coverage   93.86%   76.19%   -17.67%     
===========================================
  Files          76      216      +140     
  Lines        3360    22857    +19497     
  Branches        0     3016     +3016     
===========================================
+ Hits         3154    17417    +14263     
- Misses        206     4635     +4429     
- Partials        0      805      +805     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw pingsutw changed the title Remove upper bound for dataclasses-json Remove dataclasses-json Jan 29, 2026
@pingsutw pingsutw marked this pull request as draft January 29, 2026 22:47
@pingsutw pingsutw self-assigned this Jan 29, 2026
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants