feat: add security validation for hook execution #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add security validation layer for hook commands to prevent dangerous operations: - Block dangerous patterns: - `curl | bash`, `wget | bash` (remote code execution) - `sudo` (privilege escalation) - `eval` (arbitrary code execution) - `rm -rf` on unsafe paths - Allow safe operations without warning: - Package managers (npm, yarn, pnpm, bun install) - Docker compose commands - Basic file operations (mkdir, cp, mv, touch, echo, cat) - Git operations (fetch, pull, checkout) - Build tools (make, cargo, go) - Safe rm -rf paths: node_modules, dist, .cache, build, coverage, etc. - Show warning + require user confirmation for risky/unknown commands in interactive mode. Skip unrecognized commands in non-interactive mode. - Add `--trust-hooks` flag to bypass validation (not recommended) - Add comprehensive tests for pattern detection (50+ test cases)
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
fnebenfuehr
deleted the
claude/add-hook-security-validation-01G4uFsZngs9bejDTExD2bfV
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add security validation layer for hook commands to prevent dangerous operations:
Block dangerous patterns:
curl | bash,wget | bash(remote code execution)sudo(privilege escalation)eval(arbitrary code execution)rm -rfon unsafe pathsAllow safe operations without warning:
Safe rm -rf paths: node_modules, dist, .cache, build, coverage, etc.
Show warning + require user confirmation for risky/unknown commands in interactive mode. Skip unrecognized commands in non-interactive mode.
Add
--trust-hooksflag to bypass validation (not recommended)Add comprehensive tests for pattern detection (50+ test cases)