New fields and relations for getSummitById function #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarcet
reviewed
Dec 20, 2024
src/actions/summit-actions.js
Outdated
| "end_date," + | ||
| "event_types,event_types.id,event_types.name,event_types.order" + | ||
| "link," + | ||
| "locations,locations.id,locations.name,locations.order,locations.class_name,locations.rooms,locations.floors," + |
There was a problem hiding this comment.
can we get rid of the locations ?
this is a lot of data .. where is this used ?
smarcet
reviewed
Dec 20, 2024
smarcet
reviewed
Dec 20, 2024
src/actions/summit-actions.js
Outdated
| "event_types.none," + | ||
| "tracks.none," + | ||
| "tracks_groups.none," + | ||
| "locations,locations.rooms,locations.floor,locations.none," + |
There was a problem hiding this comment.
see ahttps://github.com//pull/552/files#r1894005784 and https://github.com/fntechgit/summit-admin/pull/552/files#r1894004652
smarcet
requested changes
Dec 20, 2024
tomrndom
force-pushed
the
hotfix/get-summit-fields-relations
branch
from
d39609a to
a3b0071
Compare
tomrndom
force-pushed
the
hotfix/get-summit-fields-relations
branch
from
0556c80 to
f81a30b
Compare
… timezone Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
tomrndom
force-pushed
the
hotfix/get-summit-fields-relations
branch
from
859b40a to
2141af2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://tipit.avaza.com/project/view#!tab=task-pane&task=3689976
Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com