feat: add new page and route for sponsor customized form managed items #698

tomrndom · 2025-11-27T15:39:11Z

ref:

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>

Copilot

Pull request overview

This PR adds a new page and routing system for managing sponsor customized form items. It introduces functionality to view, add, edit, archive, and delete items associated with sponsor forms, including the ability to add items from an existing inventory.

Added new route /app/summits/:summit_id/sponsors/:sponsor_id/sponsor-forms/:form_id/items for managing form items
Implemented editable table with inline validation for price fields
Added ability to clone items from inventory into sponsor forms
Enhanced UI with Material-UI components for better user experience

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 19 comments.

Show a summary per file

File	Description
src/utils/constants.js	Added FOUR constant for tab index reference
src/store.js	Registered new reducer for sponsor customized form items list state
src/reducers/sponsors/sponsor-customized-form-items-list-reducer.js	New reducer to manage form items list state, pagination, and CRUD operations
src/pages/sponsors_inventory/popup/sponsor-inventory-popup.js	Updated popup to use price field component, fixed quantity field defaults, added dialog title translation
src/pages/sponsors/sponsor-forms-tab/index.js	Added navigation handler to route to manage items page
src/pages/sponsors/sponsor-forms-tab/components/manage-items/sponsor-forms-manage-items.js	New component implementing items management with search, pagination, inline editing, and archiving
src/pages/sponsors/sponsor-forms-tab/components/manage-items/sponsor-form-item-from-inventory.js	New popup component for selecting and adding items from inventory
src/pages/sponsors/edit-sponsor-page.js	Added conditional rendering for items route and tab navigation handling
src/layouts/sponsor-id-layout.js	Added new route path for form items management, improved code style
src/i18n/en.json	Added translations for form items management UI and fixed typo in "Standard rate"
src/components/mui/editable-table/mui-table-editable.js	Enhanced table with validation support for editable cells
src/actions/sponsor-forms-actions.js	Added actions for fetching, saving, deleting, archiving form items and cloning from inventory

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-16T18:37:44Z

src/pages/sponsors_inventory/popup/sponsor-inventory-popup.js

    };

-    if (fieldType.id) {
+    if (fieldType.id && onMetaFieldTypeDeleted) {


The condition checking for onMetaFieldTypeDeleted should be more specific. Adding a check for onMetaFieldTypeDeleted prevents calling an undefined function, but there's no feedback to the user or developer when this callback is missing. Consider logging a warning or ensuring this prop is always provided if fieldType.id exists.

Copilot · 2025-12-16T18:37:45Z

src/pages/sponsors/sponsor-forms-tab/components/manage-items/sponsor-forms-manage-items.js

+            <FormControlLabel
+              control={
+                <Checkbox
+                  value={hideArchived}


The variable name 'hideArchived' is misleading in this context. The checkbox's 'value' prop should be 'checked' instead. When using controlled checkboxes with FormControlLabel in Material-UI, the Checkbox component should use 'checked' prop, not 'value'.

Suggested change

value={hideArchived}

checked={hideArchived}

Copilot · 2025-12-16T18:37:45Z

src/utils/constants.js


 export const TWO = 2;

+export const FOUR = 4;


The FOUR constant is exported but its purpose is unclear from its name alone. Consider using a more descriptive name like TAB_INDEX_FORMS or FORMS_TAB_INDEX to make the code more self-documenting.

Suggested change

export const FOUR = 4;

export const TAB_INDEX_FORMS = 4;

Copilot · 2025-12-16T18:37:45Z

...pages/sponsors/sponsor-forms-tab/components/manage-items/sponsor-form-item-from-inventory.js

+  onClose: PropTypes.func.isRequired,
+  onSave: PropTypes.func.isRequired


The PropTypes definition is incomplete. It only validates onClose and onSave, but the component receives many more props from Redux (open, inventoryItems, term, order, perPage, orderDir, currentPage, totalInventoryItems, getInventoryItems) that should also have PropTypes defined for better type safety and documentation.

Suggested change

onClose: PropTypes.func.isRequired,

onSave: PropTypes.func.isRequired

open: PropTypes.bool.isRequired,

inventoryItems: PropTypes.array.isRequired,

term: PropTypes.string,

order: PropTypes.string,

perPage: PropTypes.number,

orderDir: PropTypes.string,

currentPage: PropTypes.number,

totalInventoryItems: PropTypes.number,

onClose: PropTypes.func.isRequired,

onSave: PropTypes.func.isRequired,

getInventoryItems: PropTypes.func.isRequired

Copilot · 2025-12-16T18:37:46Z

src/i18n/en.json

+        "default_quantity": "Default Quantity",
+        "add_selected": "Add Selected Items",
+        "item_updated": "Form item updated successfully",
+        "item_created": "Form item {item} updated successfully",


The translation key has a mismatch. The message says "updated successfully" but the key is "item_created". This should either be "created" instead of "updated" or the key should be changed to reflect that it's about updating.

Suggested change

"item_created": "Form item {item} updated successfully",

"item_created": "Form item {item} created successfully",

Copilot · 2025-12-16T18:37:49Z

src/reducers/sponsors/sponsor-customized-form-items-list-reducer.js

+      );
+      return { ...state, items };
+    }
+    case SPONSOR_CUSTOMIZED_FORM_ITEMS_ADDED: {


The SPONSOR_CUSTOMIZED_FORM_ITEMS_ADDED case handler returns state unchanged without any explanation. If this is intentional (perhaps because the items are fetched separately), a comment explaining this would improve code clarity.

Suggested change

case SPONSOR_CUSTOMIZED_FORM_ITEMS_ADDED: {

case SPONSOR_CUSTOMIZED_FORM_ITEMS_ADDED: {

// No state update is needed here; items are fetched separately after this action.

Copilot · 2025-12-16T18:37:49Z

src/pages/sponsors/sponsor-forms-tab/components/manage-items/sponsor-forms-manage-items.js

+      .test("max-decimals", T.translate("validation.two_decimals"), (value) => {
+        if (value === undefined || value === null) return true;
+        return /^\d+(\.\d{1,2})?$/.test(value.toString());


The validation schema test uses a regex that doesn't properly validate negative numbers with decimals. The pattern /^\d+(.\d{1,2})?$/ only matches positive numbers, but the previous validation allows negative numbers with the '-?' in the pattern. This inconsistency could cause valid negative decimal numbers to fail validation.

Copilot · 2025-12-16T18:37:49Z

src/pages/sponsors/sponsor-forms-tab/components/manage-items/sponsor-forms-manage-items.js

+import SponsorFormItemFromInventoryPopup from "./sponsor-form-item-from-inventory";
+import { parsePrice } from "../../../../../utils/currency";
+import { DEFAULT_CURRENT_PAGE } from "../../../../../utils/constants";
+// import FormTemplateDialog from "../../../../sponsors_inventory/popup/form-template-popup";


The commented-out line suggests there's a placeholder or incomplete template feature. Either this should be implemented and uncommented, or the comment should be removed if it's not part of the current feature scope.

Suggested change

// import FormTemplateDialog from "../../../../sponsors_inventory/popup/form-template-popup";

Copilot · 2025-12-16T18:37:49Z

src/pages/sponsors_inventory/popup/sponsor-inventory-popup.js

+                const hasQuantities =
+                  type === "Quantity" && (minQty != null || maxQty != null);


The validation condition has a logic issue. The expression uses != instead of !== for null checks, which is inconsistent with JavaScript best practices and could lead to unexpected behavior since != performs type coercion. For example, 0 != null is false, which might not be the intended behavior when checking if minQty is set to 0.

Copilot · 2025-12-16T18:37:50Z

src/actions/sponsor-forms-actions.js

+          })
+        );
+      })
+      .catch(console.log) // need to catch promise reject


The error handler is inconsistent. Line 1484 uses console.log to catch promise rejection, which silently swallows errors and makes debugging difficult. This should use a proper error handler like the snackbarErrorHandler used in other parts of the codebase.

Suggested change

.catch(console.log) // need to catch promise reject

.catch(snackbarErrorHandler)

smarcet

@tomrndom please review coments left on tickets

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>

tomrndom added 4 commits December 9, 2025 09:11

feat: add new page and route for sponsor customized form managed items

da81427

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>

fix: adjust ui, texts, add save and fix reducer data

893f2ec

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>

fix: clean console logs

c3f6a95

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>

fix: adjust popup title

fc25ec6

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>

tomrndom force-pushed the feature/sponsor-form-managed-items branch from 2105784 to fc25ec6 Compare December 9, 2025 12:12

tomrndom added 2 commits December 9, 2025 09:37

fix: add cell inline validation, adjust fields and validations

4e18182

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>

fix: adjust validations and meta fields delete

847ac0e

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>

smarcet requested review from Copilot and smarcet December 16, 2025 18:28

Copilot started reviewing on behalf of smarcet December 16, 2025 18:28 View session

Copilot AI reviewed Dec 16, 2025

View reviewed changes

smarcet requested changes Dec 16, 2025

View reviewed changes

tomrndom added 3 commits December 16, 2025 16:17

fix: adjust image validation, reload list after save

cd699ff

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>

fix: address changes from copilot suggestions

d5ce9f8

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>

fix: adjust impots on sponsor id layout

1a3472a

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>

		onClose: PropTypes.func.isRequired,
		onSave: PropTypes.func.isRequired

-  onClose: PropTypes.func.isRequired,
-  onSave: PropTypes.func.isRequired
+  open: PropTypes.bool.isRequired,
+  inventoryItems: PropTypes.array.isRequired,
+  term: PropTypes.string,
+  order: PropTypes.string,
+  perPage: PropTypes.number,
+  orderDir: PropTypes.string,
+  currentPage: PropTypes.number,
+  totalInventoryItems: PropTypes.number,
+  onClose: PropTypes.func.isRequired,
+  onSave: PropTypes.func.isRequired,
+  getInventoryItems: PropTypes.func.isRequired

	"item_created": "Form item {item} updated successfully",
	"item_created": "Form item {item} created successfully",

	case SPONSOR_CUSTOMIZED_FORM_ITEMS_ADDED: {
	case SPONSOR_CUSTOMIZED_FORM_ITEMS_ADDED: {
	// No state update is needed here; items are fetched separately after this action.

		const hasQuantities =
		type === "Quantity" && (minQty != null \|\| maxQty != null);

	.catch(console.log) // need to catch promise reject
	.catch(snackbarErrorHandler)

feat: add new page and route for sponsor customized form managed items #698

Are you sure you want to change the base?

feat: add new page and route for sponsor customized form managed items #698

Uh oh!

Conversation

tomrndom commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

smarcet left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tomrndom commented Nov 27, 2025 •

edited

Loading