Iterative Levenshtein distance #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can you add the benchmark first in a separate PR? |
Collaborator
Author
Yes, but most of the benchmark is failing on the current master branch :/ You think that's ok? |
Korijn
reviewed
Nov 19, 2025
Collaborator
Nevermind then... |
Korijn
approved these changes
Nov 19, 2025
berendkleinhaneveld
changed the title
Collaborator
Author
|
What's missing now is a test in the default test suite to make sure no RecursiveError will be re-introduced. Edit: hmmm, the benchmark for PRs will then fail... so I guess it's in place already :) |
Merged
berendkleinhaneveld
added a commit
that referenced
this pull request
Nov 19, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to have diffs of lists of over 200 elements, which it can't handle now because of recursion error.
Related issue: #7
Note: this is another collab between Claude Code and me. The iterative Levenshtein part went pretty well, but the padding part needed some more guidance.