Skip to content

Conversation

@LuckyPigeon
Copy link

@LuckyPigeon LuckyPigeon commented Mar 18, 2018

I find that I can't use the same branch while I'm pushing the file, so I create a new one, and this PR's purpose is because I forgot to delete all the env file while I was sending a PR, so I close all of my PR if there's a env file not being deleted, and then delete my env file and make the number of my files are the same as the master branch, and then I create a new branch so that I can submit.

@PrabhanshuAttri
Copy link
Collaborator

@LuckyPigeon Please add description while creating a PR. Also, it would be great if you could explain the purpose of the PR in the title. For this PR, you have added few comments while the title says something else.

Please update the title. Also, keep your branches in sync with the master so that there are no merge conflicts. Please read Contributing.md

@PrabhanshuAttri
Copy link
Collaborator

@LuckyPigeon Please check #66. I have added my review. Make those changes here. I will close that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants