Skip to content

Conversation

@chronark
Copy link

@chronark chronark commented Sep 26, 2024

A new cookie name is used for sessions, so all older sessions will no longer
be valid.

I could not really test this, cause there is a ton of required env variables,
but I checked the source for nextauth and it should work ™️

I didn't run prettier, cause it formatted a lot of unrelated files, which would pollute the PR

Dhruwang and others added 7 commits September 25, 2024 14:36
* fix: cache for enrollment

* fix: cache

* fix: cache

* removed usage of octokit webhook

* fixes

* fix build

---------

Co-authored-by: pandeymangg <anshuman.pandey9999@gmail.com>
A new cookie name is used for sessions, so all older sessions will no longer
be valid.

I could not really test this, cause there is a ton of required env variables,
but I checked the source for nextauth and it should work ™️
@vercel
Copy link

vercel bot commented Sep 26, 2024

@chronark is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

github-actions bot commented Sep 26, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@jobenjada
Copy link
Member

yeah I tried this but we then need to check for and handle invalid sessions which led to some secondary issues and I didn't have the time to handle that properly. Will look into it over the weekend

@chronark
Copy link
Author

Old sessions shouldn't be an issue
This will simply look for a different cookie.
The existence of another (old) cookie is irrelevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants