Skip to content

Conversation

@xypron
Copy link

@xypron xypron commented Dec 10, 2025

Avoid build failures on RISC-V.

See commit 667792408340 ("float_common.h: Support RISC-V") in https://github.com/fastfloat/fast_float

@xypron
Copy link
Author

xypron commented Dec 10, 2025

With this patch I was able to build mayo for riscv64 and display an STL file in a riscv64 VM.

@HuguesDelorme
Copy link
Member

Hello @xypron thanks for your PR
I would prefer to not patch fast_float code in mayo/src/3rdparty but instead stay aligned with latest official fast_float release
The patch for RISC-V gets merged in latest fast_float release(v8.1.0), can you get the file here and overwrite in mayo/src/3rdparty/fast_float?
It would be appreciated if you can update file mayo/src/3rdparty/commit_fast_float.txt correspondingly

Updating fast_float to the current version resolve a build failure on
RISC-V.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants