Notion: add progress bar #507
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
For large databases I think it may be worth demonstrating some progress while the initial processing is occurring, this can take a really long time so giving some indicator that's it's not just frozen and to be patient would help (unsure if we can give any 1-100 sense of progress at this stage though) Here's an example: https://www.notion.so/framer/2bdadf6e8c9680ce92c8f6d44abd5d91?v=c763738b1511469395a97cb4e78c3dca&source=copy_link |
This comment was marked as outdated.
This comment was marked as outdated.
madebyisaacr
force-pushed
the
notion-progress-bar
branch
from
48392ef to
0e1609c
Compare
|
This PR has been automatically marked as stale because it has not had any activity in the last 7 days. It will be closed if no further activity occurs in the next 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a progress bar to the Notion plugin while syncing.

This replaces the percentage in the sync button:
The design is based on the AI translate progress UI:
Testing
Question
Should we also show this modal when syncing is triggered with the sync button (syncManagedCollection mode)?