Update shell style #102
Merged
Update shell style #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Flip rule about `.sh` to align with current convention 2. Fix invalid markdown links 3. Update CI recommendation 4. Remove reference to FRTool
pbrisbin
requested review from
derelbenkoenig and
jason-lieb
and removed request for
a team
jason-lieb
approved these changes
Jun 25, 2025
pbrisbin
commented
Jun 25, 2025
Comment on lines
+14
to
+19
| An executable shoudl be opaque and not leak its implementation language. If a | ||
| script is meant to be used as libaray (e.g. with `source`), then it can end in | ||
| a `.sh` extension but should not be marked exsecutable. | ||
|
|
||
| We use to require a `.sh` extension so CI could locate files for linting, but | ||
| that is no longer how that works. |
Member
Author
There was a problem hiding this comment.
Holy cow there are some typos here. That's what I get for editing in the GitHub UI I guess :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.shto align with current convention