Add top-level CMake support #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is strongly influenced by Olivier CHURLAUD's PR that tried to add CMake support to the mhaller "upstream" in 2016, but modernised for the current CMake and KDE ECM scene. Versions required are based on what is available in Debian 12. Builds against whatever Qt versions (5 or 6 or both) are available.
If everyone used CMake this wouldn't be necessary, but consumers that expect the older pkg-config solution should still be able to do their usual thing.
Owner
|
Thanks for working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts from work done by Olivier CHURLAUD in mhaller#4 but with modernized requirements (that PR is 9 years old) and some slight simplifications. It builds against Qt5 and Qt6 by default, installing everything into the prefix but with only one copy of the header-files.
The example program is not built along with the rest, but can built as a separate project (e.g.
cd qwebdavlibExample ; cmake ...) once the library is installed.Not everything ends up in exactly the same place as with the qmake build, but for CMake consumers that shouldn't matter. I have tried to also install suitable pkgconfig files so that those consumers won't notice either.