Skip to content

Conversation

@freezy
Copy link
Owner

@freezy freezy commented Apr 20, 2025

  • Fix spelling errors in doc
  • Remove locked status from drag points
  • Make asset lib paths configurable
  • Fix tri stats in asset browser
  • Make camera orbit script more configurable with better defaults
  • Fix trigger creation for flipper correction feature.
  • Fix UV mapping for ramps and surfaces.

@freezy freezy requested a review from Copilot April 20, 2025 10:40
@freezy freezy self-assigned this Apr 20, 2025
@freezy freezy changed the title Quality of life Various Fixes Apr 20, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances quality of life by addressing documentation spelling errors, removing drag point locking, making asset library paths configurable, and refining several physics and graphics behaviors. Key changes include:

  • Removal of the IsLocked property from drag point data and related editor functionality.
  • Updates to collider setup and transformation logic for improved configurability.
  • Adjustments to asset library path handling and thumbnail lookup across the editor.

Reviewed Changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.

Show a summary per file
File Description
VisualPinball.Unity/VPT/Flipper/FlipperComponent.cs Uses a rotated matrix for flipper transformation; sets TriggerItemId for trigger components.
VisualPinball.Unity/VPT/Flipper/FlipperColliderComponent.cs Exposes TriggerItemId to support flipper correction.
VisualPinball.Unity/VPT/ColliderComponent.cs Refactors collider caching and transformation logic; removes separate kinematic collider mesh references.
VisualPinball.Unity/Physics/NativeColliders.cs Improves exception messages by including colliderId.
CommonPackables.cs, DragPoint* files, DragPointData.cs Removes references to locked state for drag points.
Various AssetBrowser and AssetLibrary files Updates thumbnail and asset meta path resolution using configurable library paths.
CameraTranslateAndOrbit.cs Introduces configurable pan, orbit and smoothing parameters with updated transform cache usage.
Documentation~/creators-guide/editor/asset-library-styleguide.md Fixes minor typos for clarity.
Comments suppressed due to low confidence (1)

VisualPinball.Unity/VisualPinball.Unity/VPT/ColliderComponent.cs:324

  • Replacing the previously passed transformation matrix with float4x4.identity may affect the intended positioning of colliders. Verify that using the identity matrix here preserves the correct collider alignment.
api.CreateColliders(ref colliders, float4x4.identity, 0.1f);

@freezy freezy merged commit 3a00922 into master Apr 20, 2025
15 checks passed
@freezy freezy deleted the feat/quality-of-life branch April 20, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants