-
Notifications
You must be signed in to change notification settings - Fork 71
Various Fixes #535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various Fixes #535
Conversation
freezy
commented
Apr 20, 2025
- Fix spelling errors in doc
- Remove locked status from drag points
- Make asset lib paths configurable
- Fix tri stats in asset browser
- Make camera orbit script more configurable with better defaults
- Fix trigger creation for flipper correction feature.
- Fix UV mapping for ramps and surfaces.
…orrection triggers, and properly render gizmos during gameplay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances quality of life by addressing documentation spelling errors, removing drag point locking, making asset library paths configurable, and refining several physics and graphics behaviors. Key changes include:
- Removal of the IsLocked property from drag point data and related editor functionality.
- Updates to collider setup and transformation logic for improved configurability.
- Adjustments to asset library path handling and thumbnail lookup across the editor.
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| VisualPinball.Unity/VPT/Flipper/FlipperComponent.cs | Uses a rotated matrix for flipper transformation; sets TriggerItemId for trigger components. |
| VisualPinball.Unity/VPT/Flipper/FlipperColliderComponent.cs | Exposes TriggerItemId to support flipper correction. |
| VisualPinball.Unity/VPT/ColliderComponent.cs | Refactors collider caching and transformation logic; removes separate kinematic collider mesh references. |
| VisualPinball.Unity/Physics/NativeColliders.cs | Improves exception messages by including colliderId. |
| CommonPackables.cs, DragPoint* files, DragPointData.cs | Removes references to locked state for drag points. |
| Various AssetBrowser and AssetLibrary files | Updates thumbnail and asset meta path resolution using configurable library paths. |
| CameraTranslateAndOrbit.cs | Introduces configurable pan, orbit and smoothing parameters with updated transform cache usage. |
| Documentation~/creators-guide/editor/asset-library-styleguide.md | Fixes minor typos for clarity. |
Comments suppressed due to low confidence (1)
VisualPinball.Unity/VisualPinball.Unity/VPT/ColliderComponent.cs:324
- Replacing the previously passed transformation matrix with float4x4.identity may affect the intended positioning of colliders. Verify that using the identity matrix here preserves the correct collider alignment.
api.CreateColliders(ref colliders, float4x4.identity, 0.1f);