fix: prevent duplicate Access-Control-Allow-Origin header when origin… #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s is empty When CORS origins configuration is empty, disable CORS headers to avoid conflicts with proxied server's CORS headers. This prevents duplicate Access-Control-Allow-Origin headers when killgrave is used as a proxy. - Add AllowedOriginValidator that returns false when origins is empty - Add comprehensive tests for PrepareAccessControl function - Maintain backward compatibility for non-empty origins configuration Fixes issue where empty origins list would cause gorilla/handlers to add default '*' origin header, conflicting with proxied server headers.
Member
|
Hi @mkrou, Thanks for your contribution! 🙌🏻 Could you please split this PR into two, separating the Dockerfile addition? |
joanlopez
reviewed
Aug 5, 2025
| } | ||
| } | ||
|
|
||
| func TestPrepareAccessControl(t *testing.T) { |
Member
There was a problem hiding this comment.
In addition to this, could you please write an "integration" test to make sure Killgrave behaves as expected? I'd also help understanding why we need it.
Thanks! 🙇🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s is empty
When CORS origins configuration is empty, disable CORS headers to avoid conflicts with proxied server's CORS headers. This prevents duplicate Access-Control-Allow-Origin headers when killgrave is used as a proxy.
Fixes issue where empty origins list would cause gorilla/handlers to add default '*' origin header, conflicting with proxied server headers.