Skip to content

Conversation

@sebcrozet
Copy link
Contributor

  • Fix the extraction of a mesh from the poisson reconstruction. Sometimes it would create meshes with holes.
  • Add PoissonReconstruction::reconstruct_trimesh and ::reconstruct_mesh_buffers for extracting
    a triangle mesh with properly wired-up topology.

@fslabs-bot fslabs-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 28, 2025
@fslabs-bot
Copy link

fslabs-bot bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MichaelBradetLegris

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sebcrozet
Copy link
Contributor Author

Pretty sure the CI is stuck. I’ll merge and publish manually.

@sebcrozet sebcrozet merged commit c872529 into main Jan 28, 2025
3 of 7 checks passed
@sebcrozet sebcrozet deleted the mc-fix branch January 28, 2025 17:01
@github-actions
Copy link

Run failed - no results found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants