Implement _cp_file for Zonal Buckets & support custom flush interval #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suni72
force-pushed
the
zonal-fix-1
branch
5 times, most recently
from
97f8716 to
9b18211
Compare
* Adds test coverage check in repo * Adds pytest covergae dependency * Update threshold for new code
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #746 +/- ##
=======================================
Coverage ? 64.72%
=======================================
Files ? 20
Lines ? 3456
Branches ? 0
=======================================
Hits ? 2237
Misses ? 1219
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Update grpc_client since MRD and AAOW now accept AsyncGrpcClient object
suni72
force-pushed
the
zonal-fix-1
branch
3 times, most recently
from
1759653 to
140e1c5
Compare
update comment in test_zb_hns_utils.py
suni72
changed the title
Collaborator
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Changes:
_cp_filelogic for Zonal buckets.aaowinitialization logic inZonalFile.python-storageSDK.python-storage.ulimitin tests to prevent "too many open files" errors.