-
Notifications
You must be signed in to change notification settings - Fork 164
Adds test coverage check in repo (#68) #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* Adds test coverage check in repo * Adds pytest covergae dependency * Update threshold for new code
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
@martindurant Can you take a quick look, if its okay with you to add test coverage check in the ci, would make remaining changes in repo and merge this PR |
| - name: Upload coverage to Codecov | ||
| uses: codecov/codecov-action@v5 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you created this secret?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not yet, was waiting for you to LGTM this PR ( in case you had any apprehensions for codecov). I ll also add codecov github app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add me in users in codecov settings. I dont have permission to see the access token
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do I do that?
I do already see some data at https://app.codecov.io/github/fsspec/gcsfs/commits
Adds automated code coverage tracking to maintain testing standards and prevent regression in future contributions.
Updates the CI pipeline to generate XML reports using
pytest-covand uploads them toCodecovfor immediate visibilityImplements a strict codecov.yml policy that fails the build if test coverage declines, ensuring all new code is adequately tested