-
-
Notifications
You must be signed in to change notification settings - Fork 116
Remove CocoaPods and Carthage support, modernize to Swift Package Manager only #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CocoaPods and Carthage support, modernize to Swift Package Manager only #128
Conversation
|
Looks like copilot doesn't understand to use the cocoapods deintegrate tool... |
Co-authored-by: fulldecent <382183+fulldecent@users.noreply.github.com>
…t SPM package Co-authored-by: fulldecent <382183+fulldecent@users.noreply.github.com>
Co-authored-by: fulldecent <382183+fulldecent@users.noreply.github.com>
|
@copilot your test failed because you are not using a valid device identifier and/or version carefully study available versions from documentation and also look up how alimofire is doing their CI to get ideas and then try again here to update tests so you can get a passing build |
…Pods cleanup Co-authored-by: fulldecent <382183+fulldecent@users.noreply.github.com>
You're absolutely right! I've now properly used |
Fixed the CI configuration with valid device identifiers and iOS versions based on Alamofire's successful setup. Updated to use working combinations like "OS=17.5,name=iPhone 15 Pro" and compatible Xcode 15.4. Also improved the test approach to build both the Swift Package and iOS Example app. Changes in commit ac6306a. |
fulldecent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got the tests to pass. Good to ship
This PR removes CocoaPods and Carthage support from FDTake as requested in #74, modernizing the project to use Swift Package Manager exclusively. This simplifies the project structure and aligns with modern Swift development practices.
Changes Made
Removed Files and Dependencies
FDTake.podspec- CocoaPods specification fileTests/CheckCocoaPodsQualityIndexes.rb- CocoaPods quality validation scriptiOS Example/iOS Example.xcworkspace- Xcode workspace that was used for CocoaPods/Carthage integrationProper CocoaPods Cleanup
pod deintegrateto properly clean up any remaining CocoaPods integration from the iOS Example projectFixed Build Issues
MobileCoreServicestoUniformTypeIdentifierskUTTypeImagewithUTType.image.identifierkUTTypeMoviewithUTType.movie.identifierUpdated CI/CD
Documentation Updates
.gitignoreto remove CocoaPods/Carthage sectionsBreaking Changes
Migration Path:
Podfileand add it via Swift Package Manager in Xcode (File > Swift Packages > Add Package Dependency)Cartfileand add it via Swift Package ManagerBenefits
Closes #74
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.