Skip to content

Fix: Remove macros from namespace when deleted #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fumitoh merged 2 commits into from
Dec 10, 2025
Merged

Fix: Remove macros from namespace when deleted #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fa93e7
Initial plan
Copilot Dec 10, 2025
1bd58c6
Fix: Remove macros from namespace when deleted
Copilot Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modelx/core/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1354,6 +1354,10 @@ def del_macro(self, name):
macro = self._macros[name]
macro.on_delete()
del self._macros[name]

# Remove from macro namespace if it exists
if self._macro_namespace is not None and name in self._macro_namespace:
del self._macro_namespace[name]

def get_macro_namespace(self):
"""Get the namespace for macro execution
Expand Down
6 changes: 6 additions & 0 deletions modelx/tests/core/model/test_macro.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,15 @@ def to_delete():

assert 'to_delete' in m.macros

# Call macro to ensure namespace is created
m.to_delete()
assert 'to_delete' in m._impl._macro_namespace

del m.to_delete

assert 'to_delete' not in m.macros
# Verify macro is also removed from the namespace (bug fix)
assert 'to_delete' not in m._impl._macro_namespace
with pytest.raises(AttributeError):
m.to_delete()

Expand Down
Loading