Fix NuosSplit operative mode changes (GREEN mode not working) #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Setting the operative mode on NuosSplit devices (e.g., Nuos Plus S2) via
set_nuos_mode()/async_set_nuos_mode()returned{"success": true}but the mode never actually changed.Root Cause
The Ariston API requires the
"old"field in the request payload to apply operative mode changes. The library was only sending{"new": value}.Fix
set_nuos_mode()andasync_set_nuos_mode()inariston_api.pyto accept and include theold_valueparameterset_water_heater_operation_mode()andasync_set_water_heater_operation_mode()innuos_split_device.pyto pass the current mode value asoldBefore
{"new": 0} # Accepted but ignoredAfter
{"new": 0, "old": 1} # Actually applies the changeRelated to fustom/ariston-remotethermo-home-assistant-v3#407