Delay socket close so to (re)send final ACK if needed. #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Socket will be closed on the next retransmission timer expiry
michau-krakow
force-pushed
the
delay_socket_close
branch
from
bbc06f9 to
817859c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The https://www.rfc-editor.org/rfc/rfc1350, section 6, Normal Termination recommends not to close client connection immediately, but rather wait for a while, as the final ACK may be lost in the network.
In such case the client would re-transmit final DATA packet expecting server to send a final ACK again.
This is also fixing #5 when socket is closed too fast, effectively causing final ACK to be lost.