Skip to content

Prevent viewpager crash #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinBlock-GC merged 8 commits into from
Feb 26, 2025
Merged

Prevent viewpager crash #151

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c535703
Delete unused test files
KevinBlock-GC Feb 26, 2025
e8c4259
Bump runner versions
KevinBlock-GC Feb 26, 2025
dd74c85
Downgrade gradle due to protobuf issue
KevinBlock-GC Feb 26, 2025
9556775
Test failure
KevinBlock-GC Feb 26, 2025
5ddc208
Revert "Test failure"
KevinBlock-GC Feb 26, 2025
f5ec48b
Prevent crash if no item is found
KevinBlock-GC Feb 26, 2025
d6098c8
Merge branch 'develop' into kevinblock/viewpager-crash
KevinBlock-GC Feb 26, 2025
556ef6e
Merge branch 'develop' into kevinblock/viewpager-crash
KevinBlock-GC Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion app/src/main/java/com/tunjid/androidx/tablists/tables/ViewPagerListAdapterFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.tunjid.androidx.tablists.tables

import android.os.Bundle
import android.util.Log
import android.view.View
import androidx.fragment.app.Fragment
import androidx.fragment.app.FragmentTransaction
Expand All @@ -21,6 +22,7 @@ import com.tunjid.androidx.tabnav.routing.routeName
import com.tunjid.androidx.uidrivers.UiState
import com.tunjid.androidx.uidrivers.callback
import com.tunjid.androidx.uidrivers.uiState
import com.tunjid.viewpager2.FragmentListAdapter
import com.tunjid.viewpager2.fragmentListAdapterOf

class ViewPagerListAdapterFragment : Fragment(R.layout.fragment_spreadsheet_parent),
Expand Down Expand Up @@ -84,7 +86,15 @@ class ViewPagerListAdapterFragment : Fragment(R.layout.fragment_spreadsheet_pare
}

override fun augmentTransaction(transaction: FragmentTransaction, incomingFragment: Fragment) {
val fragment = childFragmentManager.findFragmentByTag("f${binding.viewPager.adapter?.getItemId(binding.viewPager.currentItem)}")
val currentItem = binding.viewPager.currentItem
val containsItem = (binding.viewPager.adapter as? FragmentListAdapter<*>)?.containsItem(currentItem.toLong()) == true

if (!containsItem) {
Log.i("ViewPagerListAdapter", "Item $currentItem not found in adapter, not augmenting transaction")
return
}

val fragment = childFragmentManager.findFragmentByTag("f${binding.viewPager.adapter?.getItemId(currentItem)}")
(fragment as? Navigator.TransactionModifier)?.augmentTransaction(transaction, incomingFragment)
}

Expand Down