Add option to prevent saved state crashes #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshynes
approved these changes
Feb 26, 2025
jameshynes
left a comment
jameshynes
left a comment
There was a problem hiding this comment.
This looks great! It's a good sign that the Android navigator is performing the same check as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to suppress navigation events that happen because the fragment manager is in a saved state. This only happens when the activity has been destroyed and re-created.
I took this approach since in some cases, the app is in the background when it crashes. It also doesn't seem to mess with navigation that I can tell. It's a toggle so we can feature tag it!
Also, this is what the Android FragmentNavigator checks for as well!
Before
Screen.Recording.2025-02-26.at.2.14.07.PM.mov
After
Screen.Recording.2025-02-26.at.2.51.58.PM.mov