Skip to content

feat: add pre-filled jira link to pr template #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ben-greco wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add pre-filled jira link to pr template #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ The following code makes an impact.

## Purpose of Change

## Ticket Link
Copy link

@spencerkordecki spencerkordecki Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most repos have the autolink setting enabled, so a full example jira URL isn’t necessary since they’ll just use something like “BE-1234” which will automatically link to jira

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/configuring-autolinks-to-reference-external-resources#about-autolinks

id say putting the header for the link is good, but an example placeholder will probably cause more friction than help, and any friction is just an annoyance that will be circumvented by other means

Copy link
Contributor

@jeffatgametime jeffatgametime Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LMAO thank you @spencerkordecki - i've been meaning to shoot you a text! with this review, you did 3 things

  1. prompted me to make this repo private
  2. assured us that we need to reinstall our 7 year old Jira-GH integration
  3. got a text from me

Copy link
Contributor

@jeffatgametime jeffatgametime Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, but i remembered we made this decision intentionally. @kendallm announced it as public, too. and here's the GH doc stating the req.

Copy link
Contributor

@jeffatgametime jeffatgametime Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamietsao would you mind doing the uninstall/reinstall we were talking about?

Copy link
Author

@ben-greco ben-greco Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done FYI. Discussion in slack message between the three of us.

https://gametime.atlassian.net/browse/XX-9999

## Change Overview

## Affected Functionality
Expand Down