Rotate azimuth relative geographic north when reading CORSIKA files in sim_events.writer #1951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GernotMaier
added
the
no-changelog-needed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #1935 by implementing the rotation of azimuth values from geomagnetic north (CORSIKA convention) to geographic north (sim_events format) when reading CORSIKA IACT files. The change requires pyeventio 2.1.0, which includes pycorsikaio 0.6.0 that provides the angle_array_x_magnetic_north field needed for the coordinate transformation.
Key changes:
- Applied azimuth rotation by subtracting
angle_array_x_magnetic_northfrom the raw azimuth value when processing CORSIKA IACT file info - Updated test to verify the azimuth rotation calculation is performed correctly
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/simtools/sim_events/writer.py | Implements azimuth rotation from geomagnetic to geographic north in _process_file_info for CORSIKA IACT files |
| tests/unit_tests/sim_events/test_writer.py | Adds angle_array_x_magnetic_north field to test data and updates expected azimuth assertion to verify the rotation calculation |
|
tobiaskleiner
approved these changes
Jan 5, 2026
Collaborator
tobiaskleiner
left a comment
tobiaskleiner
left a comment
There was a problem hiding this comment.
Thanks @GernotMaier.
Contributor
Author
|
Thanks for the quick review @tobiaskleiner ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a leftover item outlined in issue #1935 - azimuth values provided in the event header by CORSIKA are relative geomagnetic north, while the sim_events format is using geographic north.
Required an updated on pyeventio to 2.1.0 (to include pycorsikaio 0.6.0).
Closes #1935.