Skip to content

Conversation

@fingolfin
Copy link
Member

This shows a way forward with PR #22: move the code specific to 4ti2 and normaliz into dedicated small helper functions. I did it here for Normaliz: the left-over 4ti2 code would be easy enough to adapt.

So the plan forward would be:

  • do the same for the 4ti2 code
  • copy the two helpers into two separate files which get loaded by extension mode
  • unify the various duplicated files you added again by calling the helpers

To make it especially smooth, you could do this:
In the main file, you have roughly this

HeLP_INTERNAL_TestSystemNormaliz:= function(arg)
  Info( HeLP_Info, 1, "Normaliz has been spcified as solver, but NormalizInterface needs to be loaded for this work");
end;

In the extension file you then have

HeLP_INTERNAL_TestSystemNormaliz := function(T, a, k, pa, temp)
  ... real code here
end;

And in HeLP_INTERNAL_TestSystem you just call HeLP_INTERNAL_TestSystemNormaliz.

Does that make sense?

@margollo
Copy link
Collaborator

Yes, sounds like a way to go! I will take care of it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants