Move normaliz specific code to HeLP_INTERNAL_TestSystemNormaliz #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows a way forward with PR #22: move the code specific to 4ti2 and normaliz into dedicated small helper functions. I did it here for Normaliz: the left-over 4ti2 code would be easy enough to adapt.
So the plan forward would be:
To make it especially smooth, you could do this:
In the main file, you have roughly this
In the extension file you then have
And in
HeLP_INTERNAL_TestSystemyou just callHeLP_INTERNAL_TestSystemNormaliz.Does that make sense?