Fix bug caused by LINS_MaxPGenerators being too low.
#67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately the method `PQuotient` ungracefully throws an error, instead of returning fail.
Collaborator
Author
|
Unfortunately the method |
fingolfin
reviewed
Mar 28, 2025
|
|
||
| # Create the Isomorphism to the group structure of the `p`-Module `M` | ||
| P := PQuotient(IH, p, 1, LINS_MaxPGenerators); | ||
| logord := Int(Log(Float(n / rH!.Index))/Log(Float(p))); |
Member
There was a problem hiding this comment.
How about
Suggested change
| logord := Int(Log(Float(n / rH!.Index))/Log(Float(p))); | |
| logord := LogInt(QuoInt(n, rH!.Index), p) + 1; |
or so?
fingolfin
reviewed
Mar 28, 2025
| # Create the Isomorphism to the group structure of the `p`-Module `M` | ||
| P := PQuotient(IH, p, 1, LINS_MaxPGenerators); | ||
| logord := Int(Log(Float(n / rH!.Index))/Log(Float(p))); | ||
| P := PQuotient(IH, p, 1, logord); |
Member
There was a problem hiding this comment.
You could already pass noninteractive in anticipation of gap-system/gap#5816 being merged into GAP?
Suggested change
| P := PQuotient(IH, p, 1, logord); | |
| P := PQuotient(IH, p, 1, logord : noninteractive); |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66